From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Sterling Augustine <saugustine@google.com>, gdb-patches@sourceware.org
Subject: Re: [commit] Re: [dwarf2_mark_helper patch] Re: [PATCH] Make interrupting tab-completion safe.
Date: Tue, 12 Jul 2011 21:42:00 -0000 [thread overview]
Message-ID: <m3wrfndwpz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110712211447.GA925@host1.jankratochvil.net> (Jan Kratochvil's message of "Tue, 12 Jul 2011 23:14:47 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> After some discussion on IRC whether QUIT should or should not be
Jan> allowed for dwarf2read this patch should be OK and I have checked
Jan> it in:
To recap, based on existing code we believe it is not only safe to have
a QUIT in the full symbol reader, but we think more should probably be
added.
psymtab reading appears to remain unsafe, or at least unexplored.
However, allowing QUITs here would also be nice.
QUITs in symtab reading imply resource leaks; however there are already
known resource leaks in this code (Jan has details). My belief is that
we should move away from obstack allocation here and to something more
fine-grained like an alloc pool.
Tom
next prev parent reply other threads:[~2011-07-12 21:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 0:19 Sterling Augustine
2011-06-12 12:12 ` Jan Kratochvil
2011-06-13 17:45 ` Sterling Augustine
2011-06-26 22:22 ` [readline patch, gdb-7.3?] Avoid free from a signal handler [Re: [PATCH] Make interrupting tab-completion safe.] Jan Kratochvil
2011-06-27 16:03 ` Joel Brobecker
2011-06-29 21:49 ` Jan Kratochvil
2011-06-29 13:54 ` [Bug-readline] " Chet Ramey
2011-06-29 20:35 ` Jan Kratochvil
2011-06-30 14:38 ` Chet Ramey
2011-07-06 16:03 ` Jan Kratochvil
2011-07-06 16:07 ` Chet Ramey
2011-07-06 17:42 ` Jan Kratochvil
2011-07-07 13:40 ` Chet Ramey
2011-07-08 16:03 ` Chet Ramey
2011-10-19 20:30 ` Jan Kratochvil
2011-10-19 17:02 ` Jan Kratochvil
2011-10-19 17:51 ` Pedro Alves
2011-10-19 18:50 ` Chet Ramey
2011-07-11 18:53 ` [PATCH] Make interrupting tab-completion safe Sterling Augustine
2011-07-11 18:54 ` Jan Kratochvil
[not found] ` <CAEG7qUxFvEoJ-E2YsoFPL-tKoK4kD3-pKn-h31uUeXQoDD2Gaw@mail.gmail.com>
2011-07-12 15:59 ` [dwarf2_mark_helper patch] " Jan Kratochvil
2011-07-12 17:48 ` Sterling Augustine
2011-07-12 18:56 ` Jan Kratochvil
2011-07-12 21:18 ` [commit] " Jan Kratochvil
2011-07-12 21:42 ` Tom Tromey [this message]
2011-07-12 22:51 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wrfndwpz.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=saugustine@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox