From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18750 invoked by alias); 12 Jul 2011 21:18:36 -0000 Received: (qmail 18742 invoked by uid 22791); 12 Jul 2011 21:18:36 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jul 2011 21:18:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6CLIIZS009996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2011 17:18:18 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6CLIIRl003219; Tue, 12 Jul 2011 17:18:18 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6CLIGSJ013714; Tue, 12 Jul 2011 17:18:17 -0400 From: Tom Tromey To: Jan Kratochvil Cc: Sterling Augustine , gdb-patches@sourceware.org Subject: Re: [commit] Re: [dwarf2_mark_helper patch] Re: [PATCH] Make interrupting tab-completion safe. References: <20110612121158.GA10611@host1.jankratochvil.net> <20110711185334.GA10138@host1.jankratochvil.net> <20110712111440.GA21949@host1.jankratochvil.net> <20110712211447.GA925@host1.jankratochvil.net> Date: Tue, 12 Jul 2011 21:42:00 -0000 In-Reply-To: <20110712211447.GA925@host1.jankratochvil.net> (Jan Kratochvil's message of "Tue, 12 Jul 2011 23:14:47 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00330.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> After some discussion on IRC whether QUIT should or should not be Jan> allowed for dwarf2read this patch should be OK and I have checked Jan> it in: To recap, based on existing code we believe it is not only safe to have a QUIT in the full symbol reader, but we think more should probably be added. psymtab reading appears to remain unsafe, or at least unexplored. However, allowing QUITs here would also be nice. QUITs in symtab reading imply resource leaks; however there are already known resource leaks in this code (Jan has details). My belief is that we should move away from obstack allocation here and to something more fine-grained like an alloc pool. Tom