Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] PR python/13345
Date: Tue, 01 Nov 2011 18:55:00 -0000	[thread overview]
Message-ID: <m3wrbj3gx2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m37h3lupk2.fsf@redhat.com> (Phil Muldoon's message of "Mon, 31	Oct 2011 15:51:57 +0000")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> 2011-10-31  Phil Muldoon  <pmuldoon@redhat.com>
Phil> 	PR Python/13345
Phil> 	* python/python.c (python_run_simple_file): Expand tilde in path.

Phil> +  python_file = PyFile_FromString (full_path, "r");
Phil> +  if (! python_file)
Phil> +    {
Phil> +      do_cleanups (cleanup);
Phil> +      gdbpy_print_stack ();
Phil> +      error (_("Error sourcing Python file"));

I think the error should say "Error while opening file: %s"
and have the file name.

Ok with that change.

Tom


      parent reply	other threads:[~2011-11-01 18:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 18:11 Phil Muldoon
2011-11-01 14:07 ` Meador Inge
2011-11-01 14:15   ` Phil Muldoon
2011-11-01 18:06     ` Meador Inge
2011-11-01 17:53   ` Tom Tromey
2011-11-01 18:55 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wrbj3gx2.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox