From: Phil Muldoon <pmuldoon@redhat.com>
To: Meador Inge <meadori@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] PR python/13345
Date: Tue, 01 Nov 2011 14:15:00 -0000 [thread overview]
Message-ID: <m3mxcgszef.fsf@redhat.com> (raw)
In-Reply-To: <4EAFFCEB.6040401@codesourcery.com> (Meador Inge's message of "Tue, 01 Nov 2011 09:06:35 -0500")
Meador Inge <meadori@codesourcery.com> writes:
> On 10/31/2011 10:51 AM, Phil Muldoon wrote:
>
>> This patch fixes a case where the tilde (~) command was being passed to
>> Python via the "source" command. Python does not understand what to do
>> with a tilde, so we have to expand it first.
>
> While I can't give an OK, I did review this and was able to reproduce
> the stated problem and the patch fixes it. So, LGTM. What about
> a test case, though? You could construct a relative path to a
> test directory from '~/'.
The only addition in the patch was tilde_expand, and an additional error
check. tilde_expand is a readline function. So we would be testing
that, more or less. I do normally write regression tests, but I felt
for this one it was not necessary as the patch is somewhat trivial.
Plus I am not sure how constructing a path with a ~ in it would work on
mingw builds? If so, and we really do want one, I can attempt to write
one.
Cheers
Phil
next prev parent reply other threads:[~2011-11-01 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 18:11 Phil Muldoon
2011-11-01 14:07 ` Meador Inge
2011-11-01 14:15 ` Phil Muldoon [this message]
2011-11-01 18:06 ` Meador Inge
2011-11-01 17:53 ` Tom Tromey
2011-11-01 18:55 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mxcgszef.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=meadori@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox