From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5859 invoked by alias); 1 Nov 2011 14:15:04 -0000 Received: (qmail 5793 invoked by uid 22791); 1 Nov 2011 14:15:02 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Nov 2011 14:14:39 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA1EEYcq020193 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 1 Nov 2011 10:14:34 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA1EEWKo017258; Tue, 1 Nov 2011 10:14:33 -0400 From: Phil Muldoon To: Meador Inge Cc: gdb-patches@sourceware.org Subject: Re: [python] [patch] PR python/13345 References: <4EAFFCEB.6040401@codesourcery.com> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Tue, 01 Nov 2011 14:15:00 -0000 In-Reply-To: <4EAFFCEB.6040401@codesourcery.com> (Meador Inge's message of "Tue, 01 Nov 2011 09:06:35 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00008.txt.bz2 Meador Inge writes: > On 10/31/2011 10:51 AM, Phil Muldoon wrote: > >> This patch fixes a case where the tilde (~) command was being passed to >> Python via the "source" command. Python does not understand what to do >> with a tilde, so we have to expand it first. > > While I can't give an OK, I did review this and was able to reproduce > the stated problem and the patch fixes it. So, LGTM. What about > a test case, though? You could construct a relative path to a > test directory from '~/'. The only addition in the patch was tilde_expand, and an additional error check. tilde_expand is a readline function. So we would be testing that, more or less. I do normally write regression tests, but I felt for this one it was not necessary as the patch is somewhat trivial. Plus I am not sure how constructing a path with a ~ in it would work on mingw builds? If so, and we really do want one, I can attempt to write one. Cheers Phil