From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84848-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27661 invoked by alias); 1 Nov 2011 18:55:41 -0000
Received: (qmail 27644 invoked by uid 22791); 1 Nov 2011 18:55:40 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Nov 2011 18:55:22 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA1ItJp1008354	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 1 Nov 2011 14:55:22 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA1HCwlN029011;	Tue, 1 Nov 2011 13:12:58 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA1HCv3f025764;	Tue, 1 Nov 2011 13:12:57 -0400
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] PR python/13345
References: <m37h3lupk2.fsf@redhat.com>
Date: Tue, 01 Nov 2011 18:55:00 -0000
In-Reply-To: <m37h3lupk2.fsf@redhat.com> (Phil Muldoon's message of "Mon, 31	Oct 2011 15:51:57 +0000")
Message-ID: <m3wrbj3gx2.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-11/txt/msg00025.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> 2011-10-31  Phil Muldoon  <pmuldoon@redhat.com>
Phil> 	PR Python/13345
Phil> 	* python/python.c (python_run_simple_file): Expand tilde in path.

Phil> +  python_file = PyFile_FromString (full_path, "r");
Phil> +  if (! python_file)
Phil> +    {
Phil> +      do_cleanups (cleanup);
Phil> +      gdbpy_print_stack ();
Phil> +      error (_("Error sourcing Python file"));

I think the error should say "Error while opening file: %s"
and have the file name.

Ok with that change.

Tom