Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: gdb-patches@sources.redhat.com
Cc: Daniel Jacobowitz <drow@mvista.com>
Subject: Re: RFA: Fix shreloc.exp test driver to pass additional flags when linking
Date: Mon, 10 Nov 2003 13:08:00 -0000	[thread overview]
Message-ID: <m3vfps74ni.fsf@redhat.com> (raw)
In-Reply-To: <20031107164045.GA32117@nevyn.them.org> (Daniel Jacobowitz's message of "Fri, 7 Nov 2003 11:40:45 -0500")

Hi Guys,

> Daniel Jacobowitz <drow@mvista.com> writes:

>> On Fri, Nov 07, 2003 at 04:36:50PM +0000, Nick Clifton wrote:
>> 
>> > An arm-elf toolchain doesn't have shared library support, does it? 
>> > Then the test should probably be disabled.
>> 
>> Is there an official way to do this.  I could create a new dejagnu
>> variable along the lines of:
>> 
>>   set_board_info gdb,no_shared_libs 1
>> 
>> and then this could be tested in shreloc.exp ?
>
> There's no particular way to do it - that would work or just
> disabling the test for [istarget *-elf] || [istarget *-coff] would
> work too.

Well that is certainly simpler.  In which case, please may I have
approval to check in this patch ?

Cheers
        Nick

gdb/testsuite/ChangeLog
2003-11-10  Nick Clifton  <nickc@redhat.com>

	* gdb.base/shreloc.exp: Do not run for targets which do not
	support shared objects.

Index: gdb/testsuite/gdb.base/shreloc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/shreloc.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 shreloc.exp
*** gdb/testsuite/gdb.base/shreloc.exp	9 Jun 2003 21:23:53 -0000	1.1
--- gdb/testsuite/gdb.base/shreloc.exp	10 Nov 2003 13:05:18 -0000
***************
*** 23,28 ****
--- 23,33 ----
  # them gets relocated at load-time. Check that gdb gets the right
  # values for the debugging and minimal symbols.
  
+ if {[istarget *-elf*] || [istarget *-coff] || [istarget *-aout]} then {
+     verbose "test skipped - shared object files not supported by this target."
+     return 0
+ }
+ 
  if $tracelevel then {
      strace $tracelevel
  }


  parent reply	other threads:[~2003-11-10 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-07 10:48 Nick Clifton
2003-11-07 14:31 ` Daniel Jacobowitz
     [not found]   ` <m3ptg4jftp.fsf@redhat.com>
     [not found]     ` <20031107164045.GA32117@nevyn.them.org>
2003-11-10 13:08       ` Nick Clifton [this message]
2003-11-11 17:06         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vfps74ni.fsf@redhat.com \
    --to=nickc@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox