From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1929 invoked by alias); 10 Nov 2003 13:08:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1922 invoked from network); 10 Nov 2003 13:08:06 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Nov 2003 13:08:06 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hAAD86M11332 for ; Mon, 10 Nov 2003 08:08:06 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hAAD85619192; Mon, 10 Nov 2003 08:08:05 -0500 Received: from localhost.localdomain.redhat.com (vpn50-15.rdu.redhat.com [172.16.50.15]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id hAAD80XS013171; Mon, 10 Nov 2003 13:08:02 GMT To: gdb-patches@sources.redhat.com Cc: Daniel Jacobowitz Subject: Re: RFA: Fix shreloc.exp test driver to pass additional flags when linking References: <20031107143153.GA26353@nevyn.them.org> <20031107164045.GA32117@nevyn.them.org> From: Nick Clifton Date: Mon, 10 Nov 2003 13:08:00 -0000 In-Reply-To: <20031107164045.GA32117@nevyn.them.org> (Daniel Jacobowitz's message of "Fri, 7 Nov 2003 11:40:45 -0500") Message-ID: User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00186.txt.bz2 Hi Guys, > Daniel Jacobowitz writes: >> On Fri, Nov 07, 2003 at 04:36:50PM +0000, Nick Clifton wrote: >> >> > An arm-elf toolchain doesn't have shared library support, does it? >> > Then the test should probably be disabled. >> >> Is there an official way to do this. I could create a new dejagnu >> variable along the lines of: >> >> set_board_info gdb,no_shared_libs 1 >> >> and then this could be tested in shreloc.exp ? > > There's no particular way to do it - that would work or just > disabling the test for [istarget *-elf] || [istarget *-coff] would > work too. Well that is certainly simpler. In which case, please may I have approval to check in this patch ? Cheers Nick gdb/testsuite/ChangeLog 2003-11-10 Nick Clifton * gdb.base/shreloc.exp: Do not run for targets which do not support shared objects. Index: gdb/testsuite/gdb.base/shreloc.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/shreloc.exp,v retrieving revision 1.1 diff -c -3 -p -r1.1 shreloc.exp *** gdb/testsuite/gdb.base/shreloc.exp 9 Jun 2003 21:23:53 -0000 1.1 --- gdb/testsuite/gdb.base/shreloc.exp 10 Nov 2003 13:05:18 -0000 *************** *** 23,28 **** --- 23,33 ---- # them gets relocated at load-time. Check that gdb gets the right # values for the debugging and minimal symbols. + if {[istarget *-elf*] || [istarget *-coff] || [istarget *-aout]} then { + verbose "test skipped - shared object files not supported by this target." + return 0 + } + if $tracelevel then { strace $tracelevel }