Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: gdb-patches@sources.redhat.com
Cc: nickc@redhat.com
Subject: RFA: Fix shreloc.exp test driver to pass additional flags when linking
Date: Fri, 07 Nov 2003 10:48:00 -0000	[thread overview]
Message-ID: <m3ekwklaio.fsf@redhat.com> (raw)

Hi Guys,

  May I have permission to apply the following patch please ?

  It fixes the shreloc.exp testsuite driver code so that when it is
  linking together the shared object files that it has created, it
  passes the -shared switch on to the linker.  This fixes a seg fault
  when the testsuite was being run on a old arm-elf toolchain.

Cheers
        Nick

2003-11-07  Nick Clifton  <nickc@redhat.com>

	* gdb.base/shreloc.exp: Pass $additional_flags to gdb_compile
	when linking together the shared object files.

Index: gdb/testsuite/gdb.base/shreloc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/shreloc.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 shreloc.exp
*** gdb/testsuite/gdb.base/shreloc.exp	9 Jun 2003 21:23:53 -0000	1.1
--- gdb/testsuite/gdb.base/shreloc.exp	7 Nov 2003 10:44:07 -0000
*************** foreach module [list "shreloc1" "shreloc
*** 56,62 ****
      }
  }
  
! if {[gdb_compile [list "${workdir}/shreloc.o" "${workdir}/shreloc1.dll" "${workdir}/shreloc2.dll"] "${workdir}/shreloc" executable debug] != ""} {
      untested "Couldn't link shreloc executable"
      return -1
  }
--- 56,62 ----
      }
  }
  
! if {[gdb_compile [list "${workdir}/shreloc.o" "${workdir}/shreloc1.dll" "${workdir}/shreloc2.dll"] "${workdir}/shreloc" executable [list debug $additional_flags]] != ""} {
      untested "Couldn't link shreloc executable"
      return -1
  }
        


             reply	other threads:[~2003-11-07 10:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-07 10:48 Nick Clifton [this message]
2003-11-07 14:31 ` Daniel Jacobowitz
     [not found]   ` <m3ptg4jftp.fsf@redhat.com>
     [not found]     ` <20031107164045.GA32117@nevyn.them.org>
2003-11-10 13:08       ` Nick Clifton
2003-11-11 17:06         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ekwklaio.fsf@redhat.com \
    --to=nickc@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox