From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29652 invoked by alias); 7 Nov 2003 10:48:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29640 invoked from network); 7 Nov 2003 10:48:20 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 7 Nov 2003 10:48:20 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hA7AmJM14565 for ; Fri, 7 Nov 2003 05:48:19 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hA7AmJ624073 for ; Fri, 7 Nov 2003 05:48:19 -0500 Received: from localhost.localdomain.redhat.com (vpn50-4.rdu.redhat.com [172.16.50.4]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id hA7AlvOQ026528; Fri, 7 Nov 2003 10:48:09 GMT To: gdb-patches@sources.redhat.com Cc: nickc@redhat.com Subject: RFA: Fix shreloc.exp test driver to pass additional flags when linking From: Nick Clifton Date: Fri, 07 Nov 2003 10:48:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00113.txt.bz2 Hi Guys, May I have permission to apply the following patch please ? It fixes the shreloc.exp testsuite driver code so that when it is linking together the shared object files that it has created, it passes the -shared switch on to the linker. This fixes a seg fault when the testsuite was being run on a old arm-elf toolchain. Cheers Nick 2003-11-07 Nick Clifton * gdb.base/shreloc.exp: Pass $additional_flags to gdb_compile when linking together the shared object files. Index: gdb/testsuite/gdb.base/shreloc.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/shreloc.exp,v retrieving revision 1.1 diff -c -3 -p -r1.1 shreloc.exp *** gdb/testsuite/gdb.base/shreloc.exp 9 Jun 2003 21:23:53 -0000 1.1 --- gdb/testsuite/gdb.base/shreloc.exp 7 Nov 2003 10:44:07 -0000 *************** foreach module [list "shreloc1" "shreloc *** 56,62 **** } } ! if {[gdb_compile [list "${workdir}/shreloc.o" "${workdir}/shreloc1.dll" "${workdir}/shreloc2.dll"] "${workdir}/shreloc" executable debug] != ""} { untested "Couldn't link shreloc executable" return -1 } --- 56,62 ---- } } ! if {[gdb_compile [list "${workdir}/shreloc.o" "${workdir}/shreloc1.dll" "${workdir}/shreloc2.dll"] "${workdir}/shreloc" executable [list debug $additional_flags]] != ""} { untested "Couldn't link shreloc executable" return -1 }