From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
Date: Sat, 30 May 2009 22:36:00 -0000 [thread overview]
Message-ID: <m3vdniw74z.fsf@fleche.redhat.com> (raw)
In-Reply-To: <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> (Paul Pluzhnikov's message of "Thu\, 28 May 2009 09\:56\:51 -0700")
>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
Tom> It has a number of minor formatting problems, mostly missing spaces
Tom> before open parens.
Paul> Sorry, these get me every time :-(
Yeah. Whatever happened to running gdb_indent.sh?
Paul> I would have used bfd_get_file_window(), but it's only compiled in
Paul> when --use-mmap was given to bfd/configure.
Paul> Is there a way to turn that on for GDB?
Paul> Is it ok to do this in gdb/dwarf2read.c:
Paul> if (info->size > 4 * pagesize && (sectp->flags & SEC_RELOC) == 0
Paul> && (abfd->flags & BFD_IN_MEMORY) == 0)
I don't know the answer to either of these.
If nobody here knows, I suggest asking on the binutils list.
If they aren't ok, maybe we could add a new BFD function for this.
Tom
next prev parent reply other threads:[~2009-05-30 22:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 0:12 Paul Pluzhnikov
2009-05-28 1:16 ` Tom Tromey
2009-05-28 16:57 ` Paul Pluzhnikov
2009-05-30 22:36 ` Tom Tromey [this message]
2009-06-11 1:40 ` Paul Pluzhnikov
2009-06-11 1:43 ` Paul Pluzhnikov
2009-06-16 19:19 ` Tom Tromey
2009-06-16 20:43 ` Paul Pluzhnikov
2009-06-16 20:59 ` Tom Tromey
2009-06-16 21:07 ` Paul Pluzhnikov
2009-06-18 9:20 ` Ken Werner
2009-06-18 14:06 ` Paul Pluzhnikov
2009-06-18 14:11 ` Paul Pluzhnikov
2009-06-18 15:02 ` Ken Werner
2009-06-18 16:33 ` Paul Pluzhnikov
2009-06-19 7:10 ` Ken Werner
2009-06-23 15:03 ` [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.] Jan Kratochvil
2009-06-23 17:35 ` Paul Pluzhnikov
2009-06-23 18:08 ` Tom Tromey
2009-06-23 18:21 ` Jan Kratochvil
2009-06-23 20:00 ` Tom Tromey
2009-06-25 19:21 ` [patch] Replace reread_symbols by load+free calls Jan Kratochvil
2009-06-25 19:57 ` Pedro Alves
2009-06-25 23:25 ` Jan Kratochvil
2009-08-02 21:04 ` cancelled: " Jan Kratochvil
2009-08-14 23:09 ` Tom Tromey
2009-08-14 23:12 ` Pedro Alves
2009-08-17 15:41 ` Tom Tromey
2011-12-18 11:54 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vdniw74z.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox