From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12840 invoked by alias); 30 May 2009 22:36:23 -0000 Received: (qmail 12831 invoked by uid 22791); 30 May 2009 22:36:22 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 30 May 2009 22:36:16 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n4UMaEG0029220 for ; Sat, 30 May 2009 18:36:14 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4UMaD35030067 for ; Sat, 30 May 2009 18:36:14 -0400 Received: from opsy.redhat.com (vpn-12-155.rdu.redhat.com [10.11.12.155]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4UMaD30009200; Sat, 30 May 2009 18:36:13 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 8A0153786E8; Sat, 30 May 2009 16:36:12 -0600 (MDT) To: Paul Pluzhnikov Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections. References: <20090527001157.934BD76BC0@localhost> <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> From: Tom Tromey Reply-To: Tom Tromey Date: Sat, 30 May 2009 22:36:00 -0000 In-Reply-To: <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> (Paul Pluzhnikov's message of "Thu\, 28 May 2009 09\:56\:51 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00655.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: Tom> It has a number of minor formatting problems, mostly missing spaces Tom> before open parens. Paul> Sorry, these get me every time :-( Yeah. Whatever happened to running gdb_indent.sh? Paul> I would have used bfd_get_file_window(), but it's only compiled in Paul> when --use-mmap was given to bfd/configure. Paul> Is there a way to turn that on for GDB? Paul> Is it ok to do this in gdb/dwarf2read.c: Paul> if (info->size > 4 * pagesize && (sectp->flags & SEC_RELOC) == 0 Paul> && (abfd->flags & BFD_IN_MEMORY) == 0) I don't know the answer to either of these. If nobody here knows, I suggest asking on the binutils list. If they aren't ok, maybe we could add a new BFD function for this. Tom