From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch][python] Add symbol, symbol table and frame block support to GDB API
Date: Tue, 23 Feb 2010 23:09:00 -0000 [thread overview]
Message-ID: <m3vddnwnv2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100219141457.GB2602@localhost.localdomain> (Phil Muldoon's message of "Fri, 19 Feb 2010 14:14:57 +0000")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
One last thing I noticed...
Phil> +/* Require a valid block. All access to block_object->block should be
Phil> + gated by this call. */
Phil> +#define BLPY_REQUIRE_VALID(block_obj, block) \
Phil> + do { \
Phil> + block = block_object_to_block (block_obj); \
Phil> + if (block == NULL) \
Phil> + { \
Phil> + PyErr_SetString (PyExc_RuntimeError, \
Phil> + "Block is invalid."); \
Phil> + return NULL; \
Phil> + } \
Phil> + } while (0)
The error message here is missing _().
The others all seem to be ok.
Tom
prev parent reply other threads:[~2010-02-23 23:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 13:42 Phil Muldoon
2010-02-01 20:54 ` Eli Zaretskii
2010-02-02 10:24 ` Phil Muldoon
2010-02-02 20:14 ` Eli Zaretskii
2010-02-03 20:55 ` Phil Muldoon
2010-02-05 10:53 ` Phil Muldoon
2010-02-05 18:06 ` Eli Zaretskii
2010-02-05 11:05 ` Eli Zaretskii
2010-02-04 23:25 ` Tom Tromey
2010-02-15 15:15 ` Phil Muldoon
2010-02-15 18:45 ` Eli Zaretskii
2010-02-15 23:39 ` Phil Muldoon
2010-02-16 4:12 ` Eli Zaretskii
2010-02-18 2:50 ` Tom Tromey
2010-02-19 14:15 ` Phil Muldoon
2010-02-19 14:28 ` Eli Zaretskii
2010-02-19 15:13 ` Phil Muldoon
2010-02-23 23:05 ` Tom Tromey
2010-02-24 16:58 ` Phil Muldoon
2010-02-24 17:22 ` Tom Tromey
2010-02-24 21:49 ` Phil Muldoon
2010-02-24 18:43 ` Eli Zaretskii
2010-02-23 23:09 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vddnwnv2.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox