From: Eli Zaretskii <eliz@gnu.org>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch][python] Add symbol, symbol table and frame block support to GDB API
Date: Tue, 16 Feb 2010 04:12:00 -0000 [thread overview]
Message-ID: <83iq9xyg6s.fsf@gnu.org> (raw)
In-Reply-To: <4B79DB26.30903@redhat.com>
> Date: Mon, 15 Feb 2010 23:39:18 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: tromey@redhat.com, gdb-patches@sourceware.org
>
> On 02/15/2010 06:43 PM, Eli Zaretskii wrote:
>
> >> What do you think?
> >
> > I like it. But I want more ;-)
> >
> >> +@defmethod Frame find_sal
> >> +Return the frame's symtab and line object.
> >> +@xref{Symbol Tables In Python}.
> >> +@end defmethod
> >
> > Sometimes "Returns", sometimes "Return". I think the latter is
> > better, and we also use it more. In any case, we should use one or
> > the other consistently.
>
>
> Ok fixed in the patch and in a few other places the patch touches.
Actually, I meant the other way around: to say "Return". That's
because you also say "Set", not "Sets", etc.
> I'm not sure if your previous Ok carries forward here.
It is OK to commit once the above single issue is resolved.
Thanks.
next prev parent reply other threads:[~2010-02-16 4:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 13:42 Phil Muldoon
2010-02-01 20:54 ` Eli Zaretskii
2010-02-02 10:24 ` Phil Muldoon
2010-02-02 20:14 ` Eli Zaretskii
2010-02-03 20:55 ` Phil Muldoon
2010-02-05 10:53 ` Phil Muldoon
2010-02-05 18:06 ` Eli Zaretskii
2010-02-05 11:05 ` Eli Zaretskii
2010-02-04 23:25 ` Tom Tromey
2010-02-15 15:15 ` Phil Muldoon
2010-02-15 18:45 ` Eli Zaretskii
2010-02-15 23:39 ` Phil Muldoon
2010-02-16 4:12 ` Eli Zaretskii [this message]
2010-02-18 2:50 ` Tom Tromey
2010-02-19 14:15 ` Phil Muldoon
2010-02-19 14:28 ` Eli Zaretskii
2010-02-19 15:13 ` Phil Muldoon
2010-02-23 23:05 ` Tom Tromey
2010-02-24 16:58 ` Phil Muldoon
2010-02-24 17:22 ` Tom Tromey
2010-02-24 21:49 ` Phil Muldoon
2010-02-24 18:43 ` Eli Zaretskii
2010-02-23 23:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83iq9xyg6s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox