From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70219-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2399 invoked by alias); 16 Feb 2010 04:12:20 -0000
Received: (qmail 2283 invoked by uid 22791); 16 Feb 2010 04:12:18 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_SORBS_WEB,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Feb 2010 04:12:14 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0KXX0040029B1L00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Tue, 16 Feb 2010 06:11:44 +0200 (IST)
Received: from HOME-C4E4A596F7 ([84.228.213.68]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KXX002LA2BJOW90@a-mtaout23.012.net.il>; Tue, 16 Feb 2010 06:11:44 +0200 (IST)
Date: Tue, 16 Feb 2010 04:12:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][python] Add symbol, symbol table and frame block support   to GDB API
In-reply-to: <4B79DB26.30903@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83iq9xyg6s.fsf@gnu.org>
References: <4B66DA35.7080701@redhat.com> <m3r5p0inxy.fsf@fleche.redhat.com> <4B796506.7010909@redhat.com> <83mxzaxrtp.fsf@gnu.org> <4B79DB26.30903@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00378.txt.bz2

> Date: Mon, 15 Feb 2010 23:39:18 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: tromey@redhat.com, gdb-patches@sourceware.org
> 
> On 02/15/2010 06:43 PM, Eli Zaretskii wrote:
> 
> >> What do you think?
> > 
> > I like it.  But I want more ;-)
> > 
> >> +@defmethod Frame find_sal
> >> +Return the frame's symtab and line object.
> >> +@xref{Symbol Tables In Python}.
> >> +@end defmethod
> > 
> > Sometimes "Returns", sometimes "Return".  I think the latter is
> > better, and we also use it more.  In any case, we should use one or
> > the other consistently.
> 
> 
> Ok fixed in the patch and in a few other places the patch touches.

Actually, I meant the other way around: to say "Return".  That's
because you also say "Set", not "Sets", etc.

> I'm not sure if your previous Ok carries forward here.

It is OK to commit once the above single issue is resolved.

Thanks.