From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70419-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29169 invoked by alias); 23 Feb 2010 23:09:47 -0000
Received: (qmail 29154 invoked by uid 22791); 23 Feb 2010 23:09:47 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Feb 2010 23:09:43 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1NN9eij005946 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Tue, 23 Feb 2010 18:09:40 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1NN9eJ6015148; 	Tue, 23 Feb 2010 18:09:40 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1NN9ds9006173; 	Tue, 23 Feb 2010 18:09:39 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id D79D63780ED; Tue, 23 Feb 2010 16:09:38 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch][python] Add symbol, symbol table and frame block support  to GDB API
References: <4B66DA35.7080701@redhat.com> <m3r5p0inxy.fsf@fleche.redhat.com> 	<4B796506.7010909@redhat.com> <m3hbpfdzqj.fsf@fleche.redhat.com> 	<20100219141457.GB2602@localhost.localdomain>
Reply-To: tromey@redhat.com
Date: Tue, 23 Feb 2010 23:09:00 -0000
In-Reply-To: <20100219141457.GB2602@localhost.localdomain> (Phil Muldoon's 	message of "Fri, 19 Feb 2010 14:14:57 +0000")
Message-ID: <m3vddnwnv2.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00578.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

One last thing I noticed...

Phil> +/* Require a valid block.  All access to block_object->block should be
Phil> +   gated by this call.  */
Phil> +#define BLPY_REQUIRE_VALID(block_obj, block)	 \
Phil> +  do {						 \
Phil> +    block = block_object_to_block (block_obj);	 \
Phil> +    if (block == NULL)				 \
Phil> +      {						 \
Phil> +	PyErr_SetString (PyExc_RuntimeError,	 \
Phil> +			 "Block is invalid.");	 \
Phil> +	return NULL;				 \
Phil> +      }						 \
Phil> +  } while (0)

The error message here is missing _().
The others all seem to be ok.

Tom