From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA 2/5] New patches to support --enable-targets=all for mingw64
Date: Fri, 10 Sep 2010 16:09:00 -0000 [thread overview]
Message-ID: <m3vd6dob9d.fsf@fleche.redhat.com> (raw)
In-Reply-To: <21924.6809640483$1284127133@news.gmane.org> (Pierre Muller's message of "Fri, 10 Sep 2010 15:58:46 +0200")
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> 2010-09-10 Pierre Muller <muller@ics.u-strasbg.fr>
Pierre> * alpha-mdebug-tdep.c (find_proc_desc): Cast SYMBOL_VALUE result to
Pierre> uintptr_t before cast to pointer to avoid warning.
I think it is better to use SYMBOL_VALUE_BYTES here.
See how this field is set in mdebugread.c:
e = ((struct mdebug_extra_func_info *)
obstack_alloc (¤t_objfile->objfile_obstack,
sizeof (struct mdebug_extra_func_info)));
memset (e, 0, sizeof (struct mdebug_extra_func_info));
SYMBOL_VALUE_BYTES (s) = (gdb_byte *) e;
This is ok with that change.
Tom
next parent reply other threads:[~2010-09-10 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <21924.6809640483$1284127133@news.gmane.org>
2010-09-10 16:09 ` Tom Tromey [this message]
2010-09-10 19:02 ` Pierre Muller
2010-09-13 18:34 ` Joel Brobecker
2010-09-10 14:11 Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vd6dob9d.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox