From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75531-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22862 invoked by alias); 10 Sep 2010 15:43:07 -0000
Received: (qmail 22853 invoked by uid 22791); 10 Sep 2010 15:43:07 -0000
X-SWARE-Spam-Status: No, hits=-5.4 required=5.0	tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Sep 2010 15:43:02 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8AFgu0u026385	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 10 Sep 2010 11:42:57 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8AFgt6q009571;	Fri, 10 Sep 2010 11:42:55 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8AFgsCt017172;	Fri, 10 Sep 2010 11:42:55 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 421523792BD; Fri, 10 Sep 2010 09:42:54 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA 2/5] New patches to support --enable-targets=all for mingw64
References: <21924.6809640483$1284127133@news.gmane.org>
Date: Fri, 10 Sep 2010 16:09:00 -0000
In-Reply-To: <21924.6809640483$1284127133@news.gmane.org> (Pierre Muller's	message of "Fri, 10 Sep 2010 15:58:46 +0200")
Message-ID: <m3vd6dob9d.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-09/txt/msg00226.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> 2010-09-10  Pierre Muller  <muller@ics.u-strasbg.fr>

Pierre> 	* alpha-mdebug-tdep.c (find_proc_desc): Cast SYMBOL_VALUE result to
Pierre> 	uintptr_t before cast to pointer to avoid warning.

I think it is better to use SYMBOL_VALUE_BYTES here.
See how this field is set in mdebugread.c:

	  e = ((struct mdebug_extra_func_info *)
	       obstack_alloc (&current_objfile->objfile_obstack,
			      sizeof (struct mdebug_extra_func_info)));
	  memset (e, 0, sizeof (struct mdebug_extra_func_info));
	  SYMBOL_VALUE_BYTES (s) = (gdb_byte *) e;

This is ok with that change.

Tom