Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: 'Tom Tromey' <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 2/5] New patches to support --enable-targets=all for mingw64
Date: Mon, 13 Sep 2010 18:34:00 -0000	[thread overview]
Message-ID: <20100913175832.GB3845@adacore.com> (raw)
In-Reply-To: <004f01cb5102$8dfe0350$a9fa09f0$@muller@ics-cnrs.unistra.fr>

> +2010-09-10  Pierre Muller  <muller@ics.u-strasbg.fr>
> +
> +       * alpha-mdebug-tdep.c (find_proc_desc): Use SYMBOL_VALUE_BYTES macro
> +       before cast to pointer to avoid warning.

And I confirm that this should be the correct fix. If you look at
the code in mdebugread.c, where we create the procedure descriptor
data, we store it with:

          SYMBOL_VALUE_BYTES (s) = (gdb_byte *) e;

Thanks for fixing this.
-- 
Joel


  reply	other threads:[~2010-09-13 17:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <21924.6809640483$1284127133@news.gmane.org>
2010-09-10 16:09 ` Tom Tromey
2010-09-10 19:02   ` Pierre Muller
2010-09-13 18:34     ` Joel Brobecker [this message]
2010-09-10 14:11 Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100913175832.GB3845@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox