From: Tom Tromey <tromey@redhat.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: patch: solib_break from _r_debug.r_brk
Date: Mon, 03 Oct 2011 20:12:00 -0000 [thread overview]
Message-ID: <m3vcs5rg0v.fsf@fleche.redhat.com> (raw)
In-Reply-To: <j621ob$lv5$1@dough.gmane.org> (Aleksandar Ristovski's message of "Thu, 29 Sep 2011 11:10:03 -0400")
>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:
Aleksandar> + const unsigned ptrsz
Aleksandar> + = builtin_type (target_gdbarch)->builtin_func_ptr->length;
You should use TYPE_LENGTH here, not ->length.
Aleksandar> <date> Aleksandar Ristovski <aristovski@qnx.com>
Aleksandar> * solib-svr4.c (svr4_fetch_solib_break_from_r_debug): New.
Aleksandar> (enable_break): Use new function.
I don't really know much about this area; I think it would be better for
someone else to review the patch. Be sure to ping it weekly. After a
decent interval without replies I will take a stab at it.
Tom
next prev parent reply other threads:[~2011-10-03 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 13:57 Aleksandar Ristovski
2011-09-29 14:04 ` Marek Polacek
2011-09-29 14:32 ` Aleksandar Ristovski
2011-09-29 15:15 ` Aleksandar Ristovski
2011-10-03 19:51 ` Aleksandar Ristovski
2011-10-03 20:12 ` Tom Tromey [this message]
2011-10-03 20:40 ` Aleksandar Ristovski
2011-10-04 16:58 ` Tom Tromey
2011-10-04 17:59 ` Aleksandar Ristovski
2011-10-10 2:32 ` Daniel Jacobowitz
2011-10-12 21:16 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vcs5rg0v.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox