Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sources.redhat.com
Subject: Re: patch: solib_break from _r_debug.r_brk
Date: Mon, 03 Oct 2011 19:51:00 -0000	[thread overview]
Message-ID: <j6d3ml$us7$1@dough.gmane.org> (raw)
In-Reply-To: <j621ob$lv5$1@dough.gmane.org>

I will have to withdraw this patch.

The reason is that on gnu ld, this would not work since _r_debug is 
initialized differently, causing it to always read zero.

In theory, when attaching to a running process, this patch could still 
yield sensible results, but then I'm not sure it is generic enough to 
warrant inclusion in the official sources.


For completeness, here are two other things I have found further testing 
the patch on gnu/linux:

sym->section for _r_debug will be SEC_ALLOC so cmp_name_and_sec_flags 
would always return 0.

Second issue is that once the symbol is correctly found, fetched address 
would have to be checked for relocation since it could be already 
relocated in case of attaching to a running process.


Due to above, even though the patch works fine for me, I see no point 
pursuing it further for fsf gdb.


Thanks,

Aleksandar


  reply	other threads:[~2011-10-03 19:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29 13:57 Aleksandar Ristovski
2011-09-29 14:04 ` Marek Polacek
2011-09-29 14:32   ` Aleksandar Ristovski
2011-09-29 15:15     ` Aleksandar Ristovski
2011-10-03 19:51       ` Aleksandar Ristovski [this message]
2011-10-03 20:12       ` Tom Tromey
2011-10-03 20:40         ` Aleksandar Ristovski
2011-10-04 16:58           ` Tom Tromey
2011-10-04 17:59             ` Aleksandar Ristovski
2011-10-10  2:32           ` Daniel Jacobowitz
2011-10-12 21:16 ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='j6d3ml$us7$1@dough.gmane.org' \
    --to=aristovski@qnx.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox