From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84044-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26613 invoked by alias); 3 Oct 2011 20:12:42 -0000
Received: (qmail 26456 invoked by uid 22791); 3 Oct 2011 20:12:39 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Oct 2011 20:12:18 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p93KCIHL007162	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sources.redhat.com>; Mon, 3 Oct 2011 16:12:18 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p93KCIUC013553;	Mon, 3 Oct 2011 16:12:18 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p93KCGwx025511;	Mon, 3 Oct 2011 16:12:17 -0400
From: Tom Tromey <tromey@redhat.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: patch: solib_break from _r_debug.r_brk
References: <j61tbv$l88$1@dough.gmane.org> <4E847A11.6080800@redhat.com>	<j61v49$2ee$1@dough.gmane.org> <j621ob$lv5$1@dough.gmane.org>
Date: Mon, 03 Oct 2011 20:12:00 -0000
In-Reply-To: <j621ob$lv5$1@dough.gmane.org> (Aleksandar Ristovski's message of	"Thu, 29 Sep 2011 11:10:03 -0400")
Message-ID: <m3vcs5rg0v.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00047.txt.bz2

>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:

Aleksandar> +  const unsigned ptrsz
Aleksandar> +    = builtin_type (target_gdbarch)->builtin_func_ptr->length;

You should use TYPE_LENGTH here, not ->length.

Aleksandar> <date>  Aleksandar Ristovski  <aristovski@qnx.com>
Aleksandar>         * solib-svr4.c (svr4_fetch_solib_break_from_r_debug): New.
Aleksandar>         (enable_break): Use new function.

I don't really know much about this area; I think it would be better for
someone else to review the patch.  Be sure to ping it weekly.  After a
decent interval without replies I will take a stab at it.

Tom