From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: "Marcin Kościelnicki" <koriakin@0x04.net>
Cc: gdb-patches@sourceware.org, Yao Qi <qiyaoltc@gmail.com>,
"Metzger\, Markus T" <markus.t.metzger@intel.com>
Subject: Re: [PATCH 1/3] linux-record: Fix bad fall-through for pipe/pipe2
Date: Thu, 17 Mar 2016 12:51:00 -0000 [thread overview]
Message-ID: <m3twk59sjz.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <56E9C0C5.4090107@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielni\?\= \=\?utf-8\?Q\?cki\=22's\?\= message of "Wed, 16 Mar 2016 21:23:33 +0100")
On Wed, Mar 16 2016, Marcin Kościelnicki wrote:
> On 16/03/16 19:54, Andreas Arnez wrote:
>> This patch added handling for some syscalls to linux-record.c:
>>
>> https://sourceware.org/ml/gdb-patches/2015-10/msg00452.html
>>
>> But for both `pipe' and `pipe2' the patch lacks a statement after an
>> `if', such that the following `break' is interpreted as the `if'-body
>> instead.
>>
>> This adds the missing (return-) statements for the conditionals.
>
> Whoops, my bad. This looks like obvious patch material. Though I
> wonder why it wasn't detected earlier by someone running GCC 6 with
> its -Wmisleading-indentation warning - does it not catch it?
Right, it doesn't catch it (yet):
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66298
> Btw, it seems that cases gdb_sys_pipe2 and gdb_sys_pipe could be
> squashed into one.
Right, and a few other cases could be squashed as well. Mabye I'll post
another patch for that...
--
Andreas
next prev parent reply other threads:[~2016-03-17 12:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 18:55 [PATCH 0/3] Some cleanups in linux-record.c Andreas Arnez
2016-03-16 18:56 ` [PATCH 2/3] linux-record.c: Fix whitespace issues Andreas Arnez
2016-03-17 8:44 ` Yao Qi
2016-03-17 9:12 ` Andreas Arnez
2016-03-16 18:56 ` [PATCH 1/3] linux-record: Fix bad fall-through for pipe/pipe2 Andreas Arnez
2016-03-16 20:23 ` Marcin Kościelnicki
2016-03-17 12:51 ` Andreas Arnez [this message]
2016-03-17 8:42 ` Yao Qi
2016-03-17 9:11 ` Andreas Arnez
2016-03-16 18:57 ` [PATCH 3/3] linux-record: Simplify with record_mem_at_reg() Andreas Arnez
2016-03-17 8:45 ` Yao Qi
2016-03-17 9:11 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3twk59sjz.fsf@oc1027705133.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=koriakin@0x04.net \
--cc=markus.t.metzger@intel.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox