From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130425 invoked by alias); 17 Mar 2016 12:51:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130416 invoked by uid 89); 17 Mar 2016 12:51:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: e06smtp08.uk.ibm.com Received: from e06smtp08.uk.ibm.com (HELO e06smtp08.uk.ibm.com) (195.75.94.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 17 Mar 2016 12:51:05 +0000 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Mar 2016 12:51:02 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp08.uk.ibm.com (192.168.101.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 17 Mar 2016 12:50:59 -0000 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id E1C1C17D8056 for ; Thu, 17 Mar 2016 12:51:30 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2HCowVZ45744246 for ; Thu, 17 Mar 2016 12:50:58 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2HCovVB017839 for ; Thu, 17 Mar 2016 06:50:58 -0600 Received: from oc1027705133.ibm.com (dyn-9-152-212-180.boeblingen.de.ibm.com [9.152.212.180]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2HCouqK017806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 17 Mar 2016 06:50:57 -0600 From: Andreas Arnez To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: gdb-patches@sourceware.org, Yao Qi , "Metzger\, Markus T" Subject: Re: [PATCH 1/3] linux-record: Fix bad fall-through for pipe/pipe2 References: <1458154517-25441-1-git-send-email-arnez@linux.vnet.ibm.com> <1458154517-25441-2-git-send-email-arnez@linux.vnet.ibm.com> <56E9C0C5.4090107@0x04.net> Date: Thu, 17 Mar 2016 12:51:00 -0000 In-Reply-To: <56E9C0C5.4090107@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielni\?\= \=\?utf-8\?Q\?cki\=22's\?\= message of "Wed, 16 Mar 2016 21:23:33 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031712-0033-0000-0000-000006831649 X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00310.txt.bz2 On Wed, Mar 16 2016, Marcin Ko=C5=9Bcielnicki wrote: > On 16/03/16 19:54, Andreas Arnez wrote: >> This patch added handling for some syscalls to linux-record.c: >> >> https://sourceware.org/ml/gdb-patches/2015-10/msg00452.html >> >> But for both `pipe' and `pipe2' the patch lacks a statement after an >> `if', such that the following `break' is interpreted as the `if'-body >> instead. >> >> This adds the missing (return-) statements for the conditionals. > > Whoops, my bad. This looks like obvious patch material. Though I > wonder why it wasn't detected earlier by someone running GCC 6 with > its -Wmisleading-indentation warning - does it not catch it? Right, it doesn't catch it (yet): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D66298 > Btw, it seems that cases gdb_sys_pipe2 and gdb_sys_pipe could be > squashed into one. Right, and a few other cases could be squashed as well. Mabye I'll post another patch for that... -- Andreas