Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: Yao Qi <qiyaoltc@gmail.com>,
	       "Metzger, Markus T" <markus.t.metzger@intel.com>
Subject: [PATCH 0/3] Some cleanups in linux-record.c
Date: Wed, 16 Mar 2016 18:55:00 -0000	[thread overview]
Message-ID: <1458154517-25441-1-git-send-email-arnez@linux.vnet.ibm.com> (raw)

This is a follow-up to this patch:

  https://sourceware.org/ml/gdb-patches/2016-03/msg00239.html

As pointed out by Markus Metzger, the added lines in that patch used
tabified indentation, whereas much of the existing code in the file used
spaces for indentation instead.  He suggested to "either fix it for the
entire function in a separate patch or preserve the broken indentation."
This series implements the first option.  While fixing the whitespace
issues I also found a bug and added a fix to this series as well.

Patch #1 fixes an inadvertent fall-through to the next case statement.
Patch #2 fixes all whitespace issues in linux-record.c.  Patch #3 is a new
version of the original patch above, with the following improvements:

* Consequently keep invocations of record_mem_at_reg to a single line if
  staying within the ("soft") limit of 74 chars.

* Remove braces in the handling for `readlink', since the block is not
  needed anymore.

* Use record_mem_at_reg at two further places that were overlooked before.


Andreas Arnez (3):
  linux-record: Fix bad fall-through for pipe/pipe2
  linux-record.c: Fix whitespace issues
  linux-record: Simplify with record_mem_at_reg()

 gdb/linux-record.c | 2226 +++++++++++++++++++++++-----------------------------
 1 file changed, 989 insertions(+), 1237 deletions(-)

-- 
2.5.0


             reply	other threads:[~2016-03-16 18:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 18:55 Andreas Arnez [this message]
2016-03-16 18:56 ` [PATCH 1/3] linux-record: Fix bad fall-through for pipe/pipe2 Andreas Arnez
2016-03-16 20:23   ` Marcin Kościelnicki
2016-03-17 12:51     ` Andreas Arnez
2016-03-17  8:42   ` Yao Qi
2016-03-17  9:11     ` Andreas Arnez
2016-03-16 18:56 ` [PATCH 2/3] linux-record.c: Fix whitespace issues Andreas Arnez
2016-03-17  8:44   ` Yao Qi
2016-03-17  9:12     ` Andreas Arnez
2016-03-16 18:57 ` [PATCH 3/3] linux-record: Simplify with record_mem_at_reg() Andreas Arnez
2016-03-17  8:45   ` Yao Qi
2016-03-17  9:11     ` Andreas Arnez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458154517-25441-1-git-send-email-arnez@linux.vnet.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox