From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112173 invoked by alias); 16 Mar 2016 18:55:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112158 invoked by uid 89); 16 Mar 2016 18:55:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=staying, cleanups, Hx-languages-length:1365, overlooked X-HELO: e06smtp06.uk.ibm.com Received: from e06smtp06.uk.ibm.com (HELO e06smtp06.uk.ibm.com) (195.75.94.102) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 16 Mar 2016 18:55:24 +0000 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 Mar 2016 18:55:20 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp06.uk.ibm.com (192.168.101.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 16 Mar 2016 18:55:18 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9CD55219005F for ; Wed, 16 Mar 2016 18:55:00 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2GItI5P65404998 for ; Wed, 16 Mar 2016 18:55:18 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2GItHmD029743 for ; Wed, 16 Mar 2016 14:55:18 -0400 Received: from oc1027705133.ibm.com (dyn-9-152-212-180.boeblingen.de.ibm.com [9.152.212.180]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2GItHle029728; Wed, 16 Mar 2016 14:55:17 -0400 From: Andreas Arnez To: gdb-patches@sourceware.org Cc: Yao Qi , "Metzger, Markus T" Subject: [PATCH 0/3] Some cleanups in linux-record.c Date: Wed, 16 Mar 2016 18:55:00 -0000 Message-Id: <1458154517-25441-1-git-send-email-arnez@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031618-0025-0000-0000-0000068378DD X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00265.txt.bz2 This is a follow-up to this patch: https://sourceware.org/ml/gdb-patches/2016-03/msg00239.html As pointed out by Markus Metzger, the added lines in that patch used tabified indentation, whereas much of the existing code in the file used spaces for indentation instead. He suggested to "either fix it for the entire function in a separate patch or preserve the broken indentation." This series implements the first option. While fixing the whitespace issues I also found a bug and added a fix to this series as well. Patch #1 fixes an inadvertent fall-through to the next case statement. Patch #2 fixes all whitespace issues in linux-record.c. Patch #3 is a new version of the original patch above, with the following improvements: * Consequently keep invocations of record_mem_at_reg to a single line if staying within the ("soft") limit of 74 chars. * Remove braces in the handling for `readlink', since the block is not needed anymore. * Use record_mem_at_reg at two further places that were overlooked before. Andreas Arnez (3): linux-record: Fix bad fall-through for pipe/pipe2 linux-record.c: Fix whitespace issues linux-record: Simplify with record_mem_at_reg() gdb/linux-record.c | 2226 +++++++++++++++++++++++----------------------------- 1 file changed, 989 insertions(+), 1237 deletions(-) -- 2.5.0