From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: DW_OP_call_frame_cfa, again
Date: Tue, 01 Sep 2009 23:41:00 -0000 [thread overview]
Message-ID: <m3r5uqqlm4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <e394668d0909011607j256661d2ue6a7c9ddf3fa6a49@mail.gmail.com> (Doug Evans's message of "Tue, 1 Sep 2009 16:07:30 -0700")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> I hate to nitpick on style issues (much :-)) but since this one
Doug> bothers me, and I'm not clear on what the rules are, and there are
Doug> clear rules for other things, I thought I'd bring it up.
Doug> IWBN IMHO to require a blank line between a function's comment and its
Doug> definition. It helps readability (to me anyway).
Doug> I notice this patch has a mixture of both having the blank line and
Doug> not having it.
Yeah, I'm inconsistent about that.
I will fix it up.
Tom
next prev parent reply other threads:[~2009-09-01 23:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 0:52 Tom Tromey
2009-09-01 18:08 ` Tom Tromey
2009-09-01 23:07 ` Doug Evans
2009-09-01 23:41 ` Tom Tromey [this message]
2009-09-01 23:24 ` Pedro Alves
2009-09-01 23:47 ` Tom Tromey
2009-09-02 14:53 ` Tom Tromey
2009-09-02 14:59 ` Pedro Alves
2009-09-02 16:48 ` Tom Tromey
2009-09-02 17:01 ` Pedro Alves
2009-09-01 22:50 ` Daniel Jacobowitz
2009-09-01 23:51 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5uqqlm4.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox