From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: DW_OP_call_frame_cfa, again
Date: Tue, 01 Sep 2009 23:47:00 -0000 [thread overview]
Message-ID: <m3my5eqlbb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200909020023.57398.pedro@codesourcery.com> (Pedro Alves's message of "Wed, 2 Sep 2009 00:23:56 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>> +/* CFA accesses require a frame. */
>> +static CORE_ADDR
>> +needs_frame_frame_cfa (void *baton)
>> +{
>> + struct needs_frame_baton *nf_baton = baton;
>> + nf_baton->needs_frame = 1;
>> + return 1;
>> +}
>> +
Pedro> Return type is CORE_ADDR, but it returns 1?
Yes, just like needs_frame_read_reg and needs_frame_tls_address in the
same section. The result is arbitrary, in this code the expression is
being evaluated for its side effect of computing needs_frame.
I am not really certain that this code always works. It seems to me
that it won't handle branches properly. But, that is a not a bug
introduced by my change.
Pedro> Stale comment.
Thanks, I'll fix it.
Tom
next prev parent reply other threads:[~2009-09-01 23:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 0:52 Tom Tromey
2009-09-01 18:08 ` Tom Tromey
2009-09-01 23:07 ` Doug Evans
2009-09-01 23:41 ` Tom Tromey
2009-09-01 23:24 ` Pedro Alves
2009-09-01 23:47 ` Tom Tromey [this message]
2009-09-02 14:53 ` Tom Tromey
2009-09-02 14:59 ` Pedro Alves
2009-09-02 16:48 ` Tom Tromey
2009-09-02 17:01 ` Pedro Alves
2009-09-01 22:50 ` Daniel Jacobowitz
2009-09-01 23:51 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3my5eqlbb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox