From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66448-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12003 invoked by alias); 1 Sep 2009 23:41:18 -0000
Received: (qmail 11993 invoked by uid 22791); 1 Sep 2009 23:41:18 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Sep 2009 23:41:14 +0000
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n81Nf9uj031465; 	Tue, 1 Sep 2009 19:41:09 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n81Nf8Hq031361; 	Tue, 1 Sep 2009 19:41:08 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n81Nf7HG012687; 	Tue, 1 Sep 2009 19:41:07 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 1E833378211; Tue,  1 Sep 2009 17:41:07 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: DW_OP_call_frame_cfa, again
References: <m37hxauldt.fsf@fleche.redhat.com> 	<m3skf6tu5i.fsf@fleche.redhat.com> 	<e394668d0909011607j256661d2ue6a7c9ddf3fa6a49@mail.gmail.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Tue, 01 Sep 2009 23:41:00 -0000
In-Reply-To: <e394668d0909011607j256661d2ue6a7c9ddf3fa6a49@mail.gmail.com> 	(Doug Evans's message of "Tue, 1 Sep 2009 16:07:30 -0700")
Message-ID: <m3r5uqqlm4.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00043.txt.bz2

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> I hate to nitpick on style issues (much :-)) but since this one
Doug> bothers me, and I'm not clear on what the rules are, and there are
Doug> clear rules for other things, I thought I'd bring it up.

Doug> IWBN IMHO to require a blank line between a function's comment and its
Doug> definition.  It helps readability (to me anyway).
Doug> I notice this patch has a mixture of both having the blank line and
Doug> not having it.

Yeah, I'm inconsistent about that.
I will fix it up.

Tom