[RFA] Fix bug with the JIT interface and shared libraries

[RFA] Fix bug with the JIT interface and shared libraries

[Reid Kleckner]

I uploaded the patch here and am pasting it inline below, since that
seems to the preferred review method here:

http://sourceware.org/bugzilla/show_bug.cgi?id=11094

If it looks good, would someone please apply it for me?  Thanks!

Reid



2010-02-20  Reid Kleckner  <reid@kleckner.net>

	PR gdb/11094
	* breakpoint.c (disable_breakpoints_in_unloaded_shlib): Add bp_jit_event

Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.455
diff -c -3 -r1.455 breakpoint.c
*** gdb/breakpoint.c	12 Feb 2010 01:24:09 -0000	1.455
--- gdb/breakpoint.c	20 Feb 2010 21:27:09 -0000
***************
*** 5168,5173 ****
--- 5168,5174 ----
         all breakpoints.  If we don't set shlib_disabled here, we'll try
         to insert those breakpoints and fail.  */
      if (((b->type == bp_breakpoint)
+ 	 || (b->type == bp_jit_event)
  	 || (b->type == bp_hardware_breakpoint)
  	 || (tracepoint_type (b)))
  	&& loc->pspace == current_program_space
***************
*** 5208,5214 ****
  	 || loc->loc_type == bp_loc_software_breakpoint)
  	&& solib->pspace == loc->pspace
  	&& !loc->shlib_disabled
! 	&& (b->type == bp_breakpoint || b->type == bp_hardware_breakpoint)
  	&& solib_contains_address_p (solib, loc->address))
        {
  	loc->shlib_disabled = 1;
--- 5209,5217 ----
  	 || loc->loc_type == bp_loc_software_breakpoint)
  	&& solib->pspace == loc->pspace
  	&& !loc->shlib_disabled
! 	&& (b->type == bp_breakpoint
! 	    || b->type == bp_jit_event
! 	    || b->type == bp_hardware_breakpoint)
  	&& solib_contains_address_p (solib, loc->address))
        {
  	loc->shlib_disabled = 1;

Re: [RFA] Fix bug with the JIT interface and shared libraries

[Tom Tromey]

>>>>> "Reid" == Reid Kleckner <rnk@mit.edu> writes:

Reid> I uploaded the patch here and am pasting it inline below, since that
Reid> seems to the preferred review method here:

Yeah.

Reid> http://sourceware.org/bugzilla/show_bug.cgi?id=11094
Reid> If it looks good, would someone please apply it for me?  Thanks!

It looks good to me.  I am checking it in.

The ChangeLog was incomplete, here is the one I am actually committing:

2010-03-22  Reid Kleckner  <reid@kleckner.net>

	PR gdb/11094
	* breakpoint.c (disable_breakpoints_in_unloaded_shlib): Add
	bp_jit_event.
	(disable_breakpoints_in_shlibs): Likewise.

Tom

Re: [RFA] Fix bug with the JIT interface and shared libraries

[Reid Kleckner]

Thanks!

Reid

On Mon, Mar 22, 2010 at 1:36 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Reid" == Reid Kleckner <rnk@mit.edu> writes:
>
> Reid> I uploaded the patch here and am pasting it inline below, since that
> Reid> seems to the preferred review method here:
>
> Yeah.
>
> Reid> http://sourceware.org/bugzilla/show_bug.cgi?id=11094
> Reid> If it looks good, would someone please apply it for me?  Thanks!
>
> It looks good to me.  I am checking it in.
>
> The ChangeLog was incomplete, here is the one I am actually committing:
>
> 2010-03-22  Reid Kleckner  <reid@kleckner.net>
>
>        PR gdb/11094
>        * breakpoint.c (disable_breakpoints_in_unloaded_shlib): Add
>        bp_jit_event.
>        (disable_breakpoints_in_shlibs): Likewise.
>
> Tom
>