From: Reid Kleckner <rnk@mit.edu>
To: gdb-patches@sourceware.org
Subject: [RFA] Fix bug with the JIT interface and shared libraries
Date: Thu, 18 Mar 2010 20:32:00 -0000 [thread overview]
Message-ID: <9a9942201003181331yf721b45j981831cfd4b07459@mail.gmail.com> (raw)
I uploaded the patch here and am pasting it inline below, since that
seems to the preferred review method here:
http://sourceware.org/bugzilla/show_bug.cgi?id=11094
If it looks good, would someone please apply it for me? Thanks!
Reid
2010-02-20 Reid Kleckner <reid@kleckner.net>
PR gdb/11094
* breakpoint.c (disable_breakpoints_in_unloaded_shlib): Add bp_jit_event
Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.455
diff -c -3 -r1.455 breakpoint.c
*** gdb/breakpoint.c 12 Feb 2010 01:24:09 -0000 1.455
--- gdb/breakpoint.c 20 Feb 2010 21:27:09 -0000
***************
*** 5168,5173 ****
--- 5168,5174 ----
all breakpoints. If we don't set shlib_disabled here, we'll try
to insert those breakpoints and fail. */
if (((b->type == bp_breakpoint)
+ || (b->type == bp_jit_event)
|| (b->type == bp_hardware_breakpoint)
|| (tracepoint_type (b)))
&& loc->pspace == current_program_space
***************
*** 5208,5214 ****
|| loc->loc_type == bp_loc_software_breakpoint)
&& solib->pspace == loc->pspace
&& !loc->shlib_disabled
! && (b->type == bp_breakpoint || b->type == bp_hardware_breakpoint)
&& solib_contains_address_p (solib, loc->address))
{
loc->shlib_disabled = 1;
--- 5209,5217 ----
|| loc->loc_type == bp_loc_software_breakpoint)
&& solib->pspace == loc->pspace
&& !loc->shlib_disabled
! && (b->type == bp_breakpoint
! || b->type == bp_jit_event
! || b->type == bp_hardware_breakpoint)
&& solib_contains_address_p (solib, loc->address))
{
loc->shlib_disabled = 1;
next reply other threads:[~2010-03-18 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 20:32 Reid Kleckner [this message]
2010-03-22 17:36 ` Tom Tromey
2010-03-22 18:40 ` Reid Kleckner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a9942201003181331yf721b45j981831cfd4b07459@mail.gmail.com \
--to=rnk@mit.edu \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox