From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: update device_error() prototype
Date: Tue, 30 Mar 2010 16:16:00 -0000 [thread overview]
Message-ID: <m3r5n1yecm.fsf@fleche.redhat.com> (raw)
In-Reply-To: <8339zi24r2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Mar 2010 00:32:33 +0300")
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>> From: Mike Frysinger <vapier@gentoo.org>
>> Date: Mon, 29 Mar 2010 16:39:06 -0400
>>
>> -void device_error (device *me, char* message, ...);
>> +void device_error (device *me, const char *message, ...) __attribute__((format (printf, 2, 3)));
Eli> Is this always compiled only with GCC? __attribute__ is a GCC
Eli> specific feature, AFAIK.
sim-basics.h defines __attribute__ if not using gcc. This is not really
an approach I would recommend, because different versions of gcc have
different attributes, but it is ok if you stick to a minimal subset of
attributes.
Tom
next prev parent reply other threads:[~2010-03-30 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 20:39 Mike Frysinger
2010-03-29 21:32 ` Eli Zaretskii
2010-03-29 21:59 ` Mike Frysinger
2010-03-30 16:16 ` Tom Tromey [this message]
2010-03-30 16:51 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5n1yecm.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox