From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71609-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8464 invoked by alias); 30 Mar 2010 16:16:43 -0000
Received: (qmail 8449 invoked by uid 22791); 30 Mar 2010 16:16:41 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 16:16:33 +0000
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2UGGRQ5025151 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Tue, 30 Mar 2010 12:16:27 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2UGGQMg026138; 	Tue, 30 Mar 2010 12:16:26 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2UGGPEd009524; 	Tue, 30 Mar 2010 12:16:25 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 51C1A378185; Tue, 30 Mar 2010 10:16:25 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: update device_error() prototype
References: <1269895146-3394-1-git-send-email-vapier@gentoo.org> 	<8339zi24r2.fsf@gnu.org>
Reply-To: tromey@redhat.com
Date: Tue, 30 Mar 2010 16:16:00 -0000
In-Reply-To: <8339zi24r2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Mar 	2010 00:32:33 +0300")
Message-ID: <m3r5n1yecm.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg01054.txt.bz2

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> From: Mike Frysinger <vapier@gentoo.org>
>> Date: Mon, 29 Mar 2010 16:39:06 -0400
>> 
>> -void device_error (device *me, char* message, ...);
>> +void device_error (device *me, const char *message, ...) __attribute__((format (printf, 2, 3)));

Eli> Is this always compiled only with GCC?  __attribute__ is a GCC
Eli> specific feature, AFAIK.

sim-basics.h defines __attribute__ if not using gcc.  This is not really
an approach I would recommend, because different versions of gcc have
different attributes, but it is ok if you stick to a minimal subset of
attributes.

Tom