From: Mike Frysinger <vapier@gentoo.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: update device_error() prototype
Date: Mon, 29 Mar 2010 21:59:00 -0000 [thread overview]
Message-ID: <201003291758.58256.vapier@gentoo.org> (raw)
In-Reply-To: <8339zi24r2.fsf@gnu.org>
[-- Attachment #1: Type: Text/Plain, Size: 751 bytes --]
On Monday 29 March 2010 17:32:33 Eli Zaretskii wrote:
> > From: Mike Frysinger <vapier@gentoo.org>
> > Date: Mon, 29 Mar 2010 16:39:06 -0400
> >
> > -void device_error (device *me, char* message, ...);
> > +void device_error (device *me, const char *message, ...)
> > __attribute__((format (printf, 2, 3)));
>
> Is this always compiled only with GCC? __attribute__ is a GCC
> specific feature, AFAIK.
i didnt worry about it because a lot of places in sim/common/ are using the
printf format attribute unconditionally. if this really was a problem for
people, then they'd already be broken and have more work to clean up. i'm
assuming this isnt a realistic problem because it hasnt been reported and/or a
patch posted.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-03-29 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 20:39 Mike Frysinger
2010-03-29 21:32 ` Eli Zaretskii
2010-03-29 21:59 ` Mike Frysinger [this message]
2010-03-30 16:16 ` Tom Tromey
2010-03-30 16:51 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003291758.58256.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox