From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21741 invoked by alias); 29 Mar 2010 21:59:12 -0000 Received: (qmail 21732 invoked by uid 22791); 29 Mar 2010 21:59:12 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Mar 2010 21:59:08 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id C91CE1B401F; Mon, 29 Mar 2010 21:59:06 +0000 (UTC) From: Mike Frysinger To: Eli Zaretskii Subject: Re: [PATCH] sim: update device_error() prototype Date: Mon, 29 Mar 2010 21:59:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33.1; KDE/4.4.1; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <1269895146-3394-1-git-send-email-vapier@gentoo.org> <8339zi24r2.fsf@gnu.org> In-Reply-To: <8339zi24r2.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2883756.ATAAsCoFLL"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201003291758.58256.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01027.txt.bz2 --nextPart2883756.ATAAsCoFLL Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 754 On Monday 29 March 2010 17:32:33 Eli Zaretskii wrote: > > From: Mike Frysinger > > Date: Mon, 29 Mar 2010 16:39:06 -0400 > >=20 > > -void device_error (device *me, char* message, ...); > > +void device_error (device *me, const char *message, ...) > > __attribute__((format (printf, 2, 3))); >=20 > Is this always compiled only with GCC? __attribute__ is a GCC > specific feature, AFAIK. i didnt worry about it because a lot of places in sim/common/ are using the= =20 printf format attribute unconditionally. if this really was a problem for= =20 people, then they'd already be broken and have more work to clean up. i'm= =20 assuming this isnt a realistic problem because it hasnt been reported and/o= r a=20 patch posted. -mike --nextPart2883756.ATAAsCoFLL Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLsSKiAAoJEEFjO5/oN/WBEfsP/3khArLjQ6xrNax7XCzIcX8X he/bMpIxS6E7CUeiS7uvK10jqREFJydpaBZun0hrsnqQcKY9oEi9d+aEnuQaLxbX F7OH6IOEE0EwXIQunsEU0dtmfNNLLkqE7xapaTZ3K4z6ALVefzVjtZnNn1n5+Auv lq9cMwI8pvBVfDfYnB2VlpmMMaPBhpfyCn+yb2gnbNhUkSQLo/cb/+oNV81oHtPZ 6VyF/nj5qTBiwjx/RxMc2ofLL3Y8Vg5jHGaUfW9Y0iCRlSzuf2CFMBReWQvFodSp t/IAsHyUvRNnr03Gyvg2HIC9/l6fM9gjl07PQHft4VQbPlw79B0TfRhM9kZSa7ao t440dUP5V6yvTUFqVHBlnj2IUd7y0gQX52xmlBQF5GzyP06zFfzLX3CqTMfpb/fS jO+H39f2EeYJUrYcSLgxREMdnFWZF+wLJ+bQqp1+KMI0hPTVradtq5VCfeejxkVl srzLijSIKlYJyB/bxXlNFpOThBg8QWyu8kJq483/dGnqIa43CIDA/0UpjAolyS4O XMapQeejBd787b2h9NwsG8Gu4zJUcxVo8/OMNngbRSwG7AZgv8ADIjb/02uYKEZr cJlxlC/Y7tqbg6M5bTQODcdluFC01G+ivEK2wc/8d4yeeoXCPRYe4+bspQX3rCwJ +RW3mbl83k4kLLy1oqKV =NYUu -----END PGP SIGNATURE----- --nextPart2883756.ATAAsCoFLL--