From: Tom Tromey <tromey@redhat.com>
To: Matt Rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] python prompt additions at first prompt.
Date: Wed, 03 Aug 2011 18:08:00 -0000 [thread overview]
Message-ID: <m3r5521i8d.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CACTLOFrL0opOKGAiE3j5yPyGL6Dg5TT+vW3nqg0mX1Z0krZbsQ@mail.gmail.com> (Matt Rice's message of "Sat, 30 Jul 2011 07:12:31 -0700")
>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:
Matt> I think it's ok anyways, the 'if (async_command_editing_p)' case in
Matt> display_gdb_prompt seems to cover it,
Matt> with the addition of rl_callback_handler_remove() which afaict seemed
Matt> ok to call before a handler is installed
It is really unclear to me whether or not this patch is ok.
display_gdb_prompt can early exit in a couple of cases:
1:
if (!current_interp_display_prompt_p ())
return;
(I don't think this one can happen here.)
2:
if (sync_execution && is_running (inferior_ptid))
{
[...]
rl_callback_handler_remove ();
return;
This seems like it could be possible, maybe with attach + cont from the
command line?
If that one cannot be taken, then I agree the patch is correct.
Could you try this?
Tom
next prev parent reply other threads:[~2011-08-03 18:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 22:20 Matt Rice
2011-08-01 9:51 ` Phil Muldoon
2011-08-01 14:08 ` Matt Rice
2011-08-01 14:13 ` Phil Muldoon
2011-08-01 17:44 ` Matt Rice
2011-08-02 9:07 ` Phil Muldoon
2011-08-02 17:59 ` Matt Rice
2011-08-02 20:37 ` Phil Muldoon
2011-08-03 18:08 ` Tom Tromey [this message]
2011-08-09 0:20 ` Matt Rice
2011-08-09 0:25 ` Matt Rice
2011-08-10 15:21 ` Tom Tromey
2011-08-11 12:03 ` Matt Rice
2011-08-12 13:10 ` Matt Rice
2011-08-12 14:44 ` Pedro Alves
2011-08-12 15:07 ` Matt Rice
2011-08-29 16:23 ` Matt Rice
2011-08-29 16:39 ` Pedro Alves
2011-09-02 14:31 ` Pedro Alves
2011-09-02 21:41 ` Matt Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5521i8d.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ratmice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox