From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82793-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24776 invoked by alias); 3 Aug 2011 18:08:05 -0000
Received: (qmail 24767 invoked by uid 22791); 3 Aug 2011 18:08:05 -0000
X-SWARE-Spam-Status: No, hits=-7.3 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Aug 2011 18:07:49 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p73I7m1x028977	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 3 Aug 2011 14:07:48 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p73I7m8I006362;	Wed, 3 Aug 2011 14:07:48 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p73I7kD3030921;	Wed, 3 Aug 2011 14:07:47 -0400
From: Tom Tromey <tromey@redhat.com>
To: Matt Rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] python prompt additions at first prompt.
References: <CACTLOFrL0opOKGAiE3j5yPyGL6Dg5TT+vW3nqg0mX1Z0krZbsQ@mail.gmail.com>
Date: Wed, 03 Aug 2011 18:08:00 -0000
In-Reply-To: <CACTLOFrL0opOKGAiE3j5yPyGL6Dg5TT+vW3nqg0mX1Z0krZbsQ@mail.gmail.com>	(Matt Rice's message of "Sat, 30 Jul 2011 07:12:31 -0700")
Message-ID: <m3r5521i8d.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00053.txt.bz2

>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:

Matt> I think it's ok anyways, the 'if (async_command_editing_p)' case in
Matt> display_gdb_prompt seems to cover it,
Matt> with the addition of rl_callback_handler_remove() which afaict seemed
Matt> ok to call before a handler is installed

It is really unclear to me whether or not this patch is ok.

display_gdb_prompt can early exit in a couple of cases:

1:

  if (!current_interp_display_prompt_p ())
    return;

(I don't think this one can happen here.)

2:

  if (sync_execution && is_running (inferior_ptid))
    {
[...]
      rl_callback_handler_remove ();
      return;

This seems like it could be possible, maybe with attach + cont from the
command line?

If that one cannot be taken, then I agree the patch is correct.
Could you try this?

Tom