Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Matt Rice <ratmice@gmail.com>, Tom Tromey <tromey@redhat.com>
Subject: Re: [patch] python prompt additions at first prompt.
Date: Mon, 29 Aug 2011 16:39:00 -0000	[thread overview]
Message-ID: <201108291739.17600.pedro@codesourcery.com> (raw)
In-Reply-To: <CACTLOFpDY3H+fV__yXU-FELDkGzmKn5LOLiYHSYT0FQyFw6NuA@mail.gmail.com>

On Monday 29 August 2011 17:22:48, Matt Rice wrote:
> On Fri, Aug 12, 2011 at 8:07 AM, Matt Rice <ratmice@gmail.com> wrote:
> > On Fri, Aug 12, 2011 at 7:44 AM, Pedro Alves <pedro@codesourcery.com> wrote:
> >> On Friday 12 August 2011 14:10:17, Matt Rice wrote:
> >>> it seems clearer to return early in all sync_execution cases, and
> >>> limit the potential for introducing the double prompting type of bug.
> >>> I haven't been able to find any problems with this approach.
> >>
> >> I think this breaks the pagination prompt in async mode.  Try setting
> >> a breakpoint in a loop, with a command list that just continues:
> >>
> >> (gdb) b inloop
> >> (gdb) commands
> >> Type commands for breakpoint(s) 2, one per line.
> >> End with a line saying just "end".
> >>>c
> >>>end
> >> (gdb) c
> >
> > Yeah it does, thank you for pointing this out.
> >
> 

> Here is a version of my previous patch, which doesn't suffer from this failure.
> I have added  comments explaining that we really do want to display an
> empty prompt in this case.
> 
> hopefully this clears up any confusion...

Thanks.  I'd like to take a look at this.  Let me clear a few other pending
async things first, and I'll get back on this.

-- 
Pedro Alves


  reply	other threads:[~2011-08-29 16:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-30 22:20 Matt Rice
2011-08-01  9:51 ` Phil Muldoon
2011-08-01 14:08   ` Matt Rice
2011-08-01 14:13     ` Phil Muldoon
2011-08-01 17:44       ` Matt Rice
2011-08-02  9:07         ` Phil Muldoon
2011-08-02 17:59           ` Matt Rice
2011-08-02 20:37             ` Phil Muldoon
2011-08-03 18:08 ` Tom Tromey
2011-08-09  0:20   ` Matt Rice
2011-08-09  0:25     ` Matt Rice
2011-08-10 15:21     ` Tom Tromey
2011-08-11 12:03       ` Matt Rice
2011-08-12 13:10         ` Matt Rice
2011-08-12 14:44           ` Pedro Alves
2011-08-12 15:07             ` Matt Rice
2011-08-29 16:23               ` Matt Rice
2011-08-29 16:39                 ` Pedro Alves [this message]
2011-09-02 14:31                 ` Pedro Alves
2011-09-02 21:41                   ` Matt Rice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108291739.17600.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ratmice@gmail.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox