From: Tom Tromey <tromey@redhat.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] symfile find_separate_debug_file
Date: Thu, 13 Aug 2009 22:37:00 -0000 [thread overview]
Message-ID: <m3prazl7io.fsf@fleche.redhat.com> (raw)
In-Reply-To: <h5pnol$ejf$1@ger.gmane.org> (Aleksandar Ristovski's message of "Mon\, 10 Aug 2009 14\:09\:21 -0400")
>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:
Aleksandar> * symfile.c (find_separate_debug_file): Fix the case when
Aleksandar> objfile has only basename as its name.
Aleksandar> + somewhere, unless there isn't. See allocate_objfile. */
Funny comment :)
This is ok.
It seems to me that we probably need some kind of OBJF_IS_FILE flag,
because we do have objfiles that don't come from files, but that still
have names. Constructing file names derived from these names seems
bogus.
Tom
next prev parent reply other threads:[~2009-08-13 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 18:58 Aleksandar Ristovski
2009-08-13 22:37 ` Tom Tromey [this message]
2009-08-13 22:50 ` Doug Evans
2009-08-14 0:40 ` Tom Tromey
2009-08-14 14:44 ` Aleksandar Ristovski
2009-08-14 15:45 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3prazl7io.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox