Re: [patch] symfile find_separate_debug_file

[Doug Evans <dje@google.com>]

On Thu, Aug 13, 2009 at 2:37 PM, Tom Tromey<tromey@redhat.com> wrote:
>>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:
>
> Aleksandar> * symfile.c (find_separate_debug_file): Fix the case when
> Aleksandar> objfile has only basename as its name.
>
> Aleksandar> +     somewhere, unless there isn't.  See allocate_objfile.  */
>
> Funny comment :)

Ya, reminds me of one in c++:

3.5 Program and Linkage [basic.link] paragraph 6:
"extern means static except when it doesn't"

> This is ok.
>
> It seems to me that we probably need some kind of OBJF_IS_FILE flag,
> because we do have objfiles that don't come from files, but that still
> have names.  Constructing file names derived from these names seems
> bogus.

fwiw, I wouldn't mind an elaboration of the comment, e.g. provide an
example when  "unless there isn't" happens.  Otherwise I have to go
looking and assume what I find is what the comment is referring to.