From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31414 invoked by alias); 13 Aug 2009 22:45:02 -0000 Received: (qmail 31306 invoked by uid 22791); 13 Aug 2009 22:45:01 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Aug 2009 22:44:54 +0000 Received: from zps18.corp.google.com (zps18.corp.google.com [172.25.146.18]) by smtp-out.google.com with ESMTP id n7DMioKK010297 for ; Thu, 13 Aug 2009 23:44:51 +0100 Received: from gxk21 (gxk21.prod.google.com [10.202.11.21]) by zps18.corp.google.com with ESMTP id n7DMiltI017666 for ; Thu, 13 Aug 2009 15:44:47 -0700 Received: by gxk21 with SMTP id 21so1491226gxk.3 for ; Thu, 13 Aug 2009 15:44:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.20.1 with SMTP id x1mr1883974ybi.124.1250203487022; Thu, 13 Aug 2009 15:44:47 -0700 (PDT) In-Reply-To: References: Date: Thu, 13 Aug 2009 22:50:00 -0000 Message-ID: Subject: Re: [patch] symfile find_separate_debug_file From: Doug Evans To: tromey@redhat.com Cc: Aleksandar Ristovski , gdb-patches@sources.redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00186.txt.bz2 On Thu, Aug 13, 2009 at 2:37 PM, Tom Tromey wrote: >>>>>> "Aleksandar" =3D=3D Aleksandar Ristovski writes: > > Aleksandar> * symfile.c (find_separate_debug_file): Fix the case when > Aleksandar> objfile has only basename as its name. > > Aleksandar> + =A0 =A0 somewhere, unless there isn't. =A0See allocate_objf= ile. =A0*/ > > Funny comment :) Ya, reminds me of one in c++: 3.5 Program and Linkage [basic.link] paragraph 6: "extern means static except when it doesn't" > This is ok. > > It seems to me that we probably need some kind of OBJF_IS_FILE flag, > because we do have objfiles that don't come from files, but that still > have names. =A0Constructing file names derived from these names seems > bogus. fwiw, I wouldn't mind an elaboration of the comment, e.g. provide an example when "unless there isn't" happens. Otherwise I have to go looking and assume what I find is what the comment is referring to.