From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11104 invoked by alias); 13 Aug 2009 21:41:34 -0000 Received: (qmail 11004 invoked by uid 22791); 13 Aug 2009 21:41:26 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Aug 2009 21:37:55 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7DLbrXF016103 for ; Thu, 13 Aug 2009 17:37:53 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n7DLbqU6009621 for ; Thu, 13 Aug 2009 17:37:52 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7DLbpFs003655; Thu, 13 Aug 2009 17:37:52 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 55C3C3784C5; Thu, 13 Aug 2009 15:37:51 -0600 (MDT) To: Aleksandar Ristovski Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] symfile find_separate_debug_file References: From: Tom Tromey Reply-To: tromey@redhat.com Date: Thu, 13 Aug 2009 22:37:00 -0000 In-Reply-To: (Aleksandar Ristovski's message of "Mon\, 10 Aug 2009 14\:09\:21 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00184.txt.bz2 >>>>> "Aleksandar" == Aleksandar Ristovski writes: Aleksandar> * symfile.c (find_separate_debug_file): Fix the case when Aleksandar> objfile has only basename as its name. Aleksandar> + somewhere, unless there isn't. See allocate_objfile. */ Funny comment :) This is ok. It seems to me that we probably need some kind of OBJF_IS_FILE flag, because we do have objfiles that don't come from files, but that still have names. Constructing file names derived from these names seems bogus. Tom