Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Implement support for IBM XL C for OpenCL vector ABI
Date: Fri, 04 Feb 2011 16:47:00 -0000	[thread overview]
Message-ID: <m3pqr7agrj.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201102021748.p12Hm18H010975@d06av02.portsmouth.uk.ibm.com>	(Ulrich Weigand's message of "Wed, 2 Feb 2011 18:48:00 +0100 (CET)")

>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:

Ulrich> This extra flag is defined by GDB itself, and has a value outside
Ulrich> the defined range of DW_AT_calling_convention attribute values,
Ulrich> so there should be no potential conflict.

Ulrich> Does this look reasonable?  If anyone sees a better way to implement
Ulrich> this, I'd appreciate any suggestions ...

I think it would be slightly more future-proof to choose a value in the
lo_user-hi_user range and put the new name, along with a detailed
comment, into include/dwarf2.h.

That way, if somebody finds a conflicting use, presumably they will be
editing the same place, see the comment, and change the value to
something that does not conflict.

Tom


  reply	other threads:[~2011-02-04 16:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 17:48 Ulrich Weigand
2011-02-04 16:47 ` Tom Tromey [this message]
2011-02-07 19:25   ` Ulrich Weigand
2011-02-07 20:05     ` Tom Tromey
2011-02-08 13:30       ` Ulrich Weigand
2011-02-14 12:59         ` Luis Machado
2011-02-14 12:07           ` Luis Machado
2011-02-14 13:41           ` Yao Qi
2011-10-24 17:09     ` [commit/powerpc] crash trying to allocate memory in inferior Joel Brobecker
2011-10-26 17:31       ` Ulrich Weigand
2011-10-26 18:16         ` Joel Brobecker
2011-02-13 15:38 ` [rfc] Implement support for IBM XL C for OpenCL vector ABI Mark Kettenis
2011-02-14 13:47   ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pqr7agrj.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox