From: Jim Blandy <jimb@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] Do not make up line information
Date: Wed, 22 Nov 2006 21:59:00 -0000 [thread overview]
Message-ID: <m3odqz5ei8.fsf@codesourcery.com> (raw)
In-Reply-To: <20061122203232.GB14849@nevyn.them.org> (Daniel Jacobowitz's message of "Wed, 22 Nov 2006 15:32:32 -0500")
Daniel Jacobowitz <drow@false.org> writes:
> On Wed, Nov 22, 2006 at 11:54:13AM -0800, Jim Blandy wrote:
>> Wow --- that's weird code. Where did that alt->line - 1 come from?
>>
>> If we can't find the original motivation, the change looks like an
>> obvious improvement to me.
>
> It predates all our changelogs. I imagine it predates debug info for
> inlining, and DWARF-2, too.
It seems to me that, when one can't find the rationale for something
weird after a responsible look, it's best to just replace it with
something reasonable and see what happens. Otherwise, the overall
dynamic is for things to become choked with obscure bits that nobody
can test alternatives to.
So I'd say, commit it.
next prev parent reply other threads:[~2006-11-22 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 15:42 Daniel Jacobowitz
2006-11-22 19:53 ` Jim Blandy
2006-11-22 20:32 ` Daniel Jacobowitz
2006-11-22 21:59 ` Jim Blandy [this message]
2006-11-28 16:24 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3odqz5ei8.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox