Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] Do not make up line information
Date: Wed, 22 Nov 2006 19:53:00 -0000	[thread overview]
Message-ID: <m33b8b6yvu.fsf@codesourcery.com> (raw)
In-Reply-To: <20061122154249.GA3884@nevyn.them.org> (Daniel Jacobowitz's message of "Wed, 22 Nov 2006 10:42:49 -0500")


Daniel Jacobowitz <drow@false.org> writes:
> We'll never return a line number for function "foo", because with modern
> debug info we'll have an end marker for that part of the line table,
> represented as an entry for line 0.  But if the code for foo_init has
> inlined code from any header file that foo doesn't have, we'll have another
> symtab sharing the same blockvector whose lowest PC value is after "bar".
> We'll select that as the "best match", since it's the closest thing
> following bar.  We'll subtract one from the line number (probably putting us
> on the start of an inline function definition) and report that as the
> line for bar.

Wow --- that's weird code.  Where did that alt->line - 1 come from?

If we can't find the original motivation, the change looks like an
obvious improvement to me.


  reply	other threads:[~2006-11-22 19:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-22 15:42 Daniel Jacobowitz
2006-11-22 19:53 ` Jim Blandy [this message]
2006-11-22 20:32   ` Daniel Jacobowitz
2006-11-22 21:59     ` Jim Blandy
2006-11-28 16:24       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m33b8b6yvu.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox