From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11289 invoked by alias); 22 Nov 2006 21:59:23 -0000 Received: (qmail 11281 invoked by uid 22791); 22 Nov 2006 21:59:22 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Nov 2006 21:59:13 +0000 Received: (qmail 20592 invoked from network); 22 Nov 2006 21:59:11 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Nov 2006 21:59:11 -0000 To: gdb-patches@sourceware.org Subject: Re: [rfc] Do not make up line information References: <20061122154249.GA3884@nevyn.them.org> <20061122203232.GB14849@nevyn.them.org> From: Jim Blandy Date: Wed, 22 Nov 2006 21:59:00 -0000 In-Reply-To: <20061122203232.GB14849@nevyn.them.org> (Daniel Jacobowitz's message of "Wed, 22 Nov 2006 15:32:32 -0500") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00272.txt.bz2 Daniel Jacobowitz writes: > On Wed, Nov 22, 2006 at 11:54:13AM -0800, Jim Blandy wrote: >> Wow --- that's weird code. Where did that alt->line - 1 come from? >> >> If we can't find the original motivation, the change looks like an >> obvious improvement to me. > > It predates all our changelogs. I imagine it predates debug info for > inlining, and DWARF-2, too. It seems to me that, when one can't find the rationale for something weird after a responsible look, it's best to just replace it with something reasonable and see what happens. Otherwise, the overall dynamic is for things to become choked with obscure bits that nobody can test alternatives to. So I'd say, commit it.