Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Ian Lance Taylor <iant@google.com>
Cc: gcc-patches@gcc.gnu.org,
	Binutils Development <binutils@sourceware.org>,
	        gdb-patches@sourceware.org
Subject: Re: Patch: merge src and gcc copies of dwarf2.h
Date: Mon, 29 Jun 2009 23:59:00 -0000	[thread overview]
Message-ID: <m3ocs67fs9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3k52u3j58.fsf@google.com> (Ian Lance Taylor's message of "Mon\, 29 Jun 2009 13\:00\:19 -0700")

>>>>> "Ian" == Ian Lance Taylor <iant@google.com> writes:

>> +  tem = ((unsigned int) loc->dw_loc_opc << 1) | loc->dtprel;
>> +  CHECKSUM (tem);

Ian> This appears to change the checksum, which probably doesn't matter too
Ian> much, but since it can appear in a .o file it seems to me that we might
Ian> as well keep the same checksum, as in
Ian>   tem = (loc->dtprel << 8) | ((unsigned int) loc->dw_loc_opc);

Oops, I did not realize this could end up in the .o.

Ian> This patch is OK for gcc with that change.

Thanks.  I made this change and will check it in soon.
I'll post the corresponding src patch sometime soon.

Tom


  reply	other threads:[~2009-06-29 23:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19 21:11 Tom Tromey
2009-06-20  7:17 ` Ian Lance Taylor
2009-06-29 18:13   ` Tom Tromey
2009-06-29 20:00     ` Ian Lance Taylor
2009-06-29 23:59       ` Tom Tromey [this message]
2009-06-30 19:51         ` Jakub Jelinek
2009-06-30 20:03           ` Tom Tromey
2009-07-01 21:57             ` Tom Tromey
2009-07-02  0:30               ` Ian Lance Taylor
2009-07-02 17:30                 ` Tom Tromey
2009-07-09 20:32                 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ocs67fs9.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=iant@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox