From: Ian Lance Taylor <iant@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gcc-patches@gcc.gnu.org,
Binutils Development <binutils@sourceware.org>,
gdb-patches@sourceware.org
Subject: Re: Patch: merge src and gcc copies of dwarf2.h
Date: Mon, 29 Jun 2009 20:00:00 -0000 [thread overview]
Message-ID: <m3k52u3j58.fsf@google.com> (raw)
In-Reply-To: <m363eeaoz0.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon\, 29 Jun 2009 12\:12\:35 -0600")
Tom Tromey <tromey@redhat.com> writes:
> 2009-06-29 Tom Tromey <tromey@redhat.com>
> * dwarf2.h: Remove.
> * Makefile.in (DWARF2_H): New variable.
> (except.o): Use it.
> (dwarf2out.o): Likewise.
> (dwarf2asm.o): Likewise.
> * config/i386/t-i386: Use DWARF2_H.
> * except.c: Include elf/dwarf2.h.
> * unwind-dw2.c: Include elf/dwarf2.h.
> * dwarf2out.c: Include elf/dwarf2.h.
> (dw_loc_descr_struct) <dw_loc_opc>: Now a bitfield.
> <dtprel>: New field.
> (dwarf_stack_op_name): Don't handle INTERNAL_DW_OP_tls_addr.
> (size_of_loc_descr): Likewise.
> (output_loc_operands_raw): Likewise.
> (output_loc_operands): Handle new dtprel field.
> (loc_checksum): Update.
> (loc_descriptor_from_tree_1) <VAR_DDECL>: Set dtprel field.
> * unwind-dw2-fde-glibc.c: Include elf/dwarf2.h.
> * unwind-dw2-fde.c: Include elf/dwarf2.h.
> * dwarf2asm.c: Include elf/dwarf2.h.
> * unwind-dw2-fde-darwin.c: Include elf/dwarf2.h.
> * config/mmix/mmix.c: Include elf/dwarf2.h.
> * config/rs6000/darwin-fallback.c: Include elf/dwarf2.h.
> * config/xtensa/unwind-dw2-xtensa.c: Include elf/dwarf2.h.
> * config/sh/sh.c: Include elf/dwarf2.h.
> * config/i386/i386.c: Include elf/dwarf2.h.
> 2009-06-29 Tom Tromey <tromey@redhat.com>
> * raise-gcc.c: Include elf/dwarf2.h.
> 2009-06-29 Tom Tromey <tromey@redhat.com>
> * elf/dwarf2.h: New file. Merged with gdb.
> @@ -7280,7 +7285,10 @@
> static inline void
> loc_checksum (dw_loc_descr_ref loc, struct md5_ctx *ctx)
> {
> - CHECKSUM (loc->dw_loc_opc);
> + int tem;
> +
> + tem = ((unsigned int) loc->dw_loc_opc << 1) | loc->dtprel;
> + CHECKSUM (tem);
This appears to change the checksum, which probably doesn't matter too
much, but since it can appear in a .o file it seems to me that we might
as well keep the same checksum, as in
tem = (loc->dtprel << 8) | ((unsigned int) loc->dw_loc_opc);
This patch is OK for gcc with that change.
Thanks.
Ian
next prev parent reply other threads:[~2009-06-29 20:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 21:11 Tom Tromey
2009-06-20 7:17 ` Ian Lance Taylor
2009-06-29 18:13 ` Tom Tromey
2009-06-29 20:00 ` Ian Lance Taylor [this message]
2009-06-29 23:59 ` Tom Tromey
2009-06-30 19:51 ` Jakub Jelinek
2009-06-30 20:03 ` Tom Tromey
2009-07-01 21:57 ` Tom Tromey
2009-07-02 0:30 ` Ian Lance Taylor
2009-07-02 17:30 ` Tom Tromey
2009-07-09 20:32 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k52u3j58.fsf@google.com \
--to=iant@google.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox