From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1015 invoked by alias); 29 Jun 2009 23:59:43 -0000 Received: (qmail 938 invoked by uid 22791); 29 Jun 2009 23:59:41 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Jun 2009 23:59:38 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5TNxPRU015741; Mon, 29 Jun 2009 19:59:25 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5TNxOHZ029250; Mon, 29 Jun 2009 19:59:24 -0400 Received: from opsy.redhat.com (vpn-225-41.phx2.redhat.com [10.3.225.41]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5TNxNUt016624; Mon, 29 Jun 2009 19:59:23 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id D62133784C5; Mon, 29 Jun 2009 17:59:19 -0600 (MDT) To: Ian Lance Taylor Cc: gcc-patches@gcc.gnu.org, Binutils Development , gdb-patches@sourceware.org Subject: Re: Patch: merge src and gcc copies of dwarf2.h References: From: Tom Tromey Reply-To: Tom Tromey Date: Mon, 29 Jun 2009 23:59:00 -0000 In-Reply-To: (Ian Lance Taylor's message of "Mon\, 29 Jun 2009 13\:00\:19 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00855.txt.bz2 >>>>> "Ian" == Ian Lance Taylor writes: >> + tem = ((unsigned int) loc->dw_loc_opc << 1) | loc->dtprel; >> + CHECKSUM (tem); Ian> This appears to change the checksum, which probably doesn't matter too Ian> much, but since it can appear in a .o file it seems to me that we might Ian> as well keep the same checksum, as in Ian> tem = (loc->dtprel << 8) | ((unsigned int) loc->dw_loc_opc); Oops, I did not realize this could end up in the .o. Ian> This patch is OK for gcc with that change. Thanks. I made this change and will check it in soon. I'll post the corresponding src patch sometime soon. Tom