From: Andreas Schwab <schwab@redhat.com>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: "Ulrich Weigand" <uweigand@de.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [patch] OpenCL datatypes test fixes
Date: Wed, 16 Feb 2011 10:33:00 -0000 [thread overview]
Message-ID: <m3oc6c1dm2.fsf@redhat.com> (raw)
In-Reply-To: <201102161108.54061.ken@linux.vnet.ibm.com> (Ken Werner's message of "Wed, 16 Feb 2011 11:08:54 +0100")
Ken Werner <ken@linux.vnet.ibm.com> writes:
> On Tuesday, February 15, 2011 10:01:55 pm Ulrich Weigand wrote:
>> Ken Werner wrote:
>> > -gdb_test "whatis c2" "type = char \\\[2\\\]"
>> > +gdb_test "whatis c2" "type = char2|char \\\[2\\\]"
>>
>> Don't we need some parentheses here (and everywere you've
>> introduced alternatives via |)? Otherwise, it seems that
>> this would stop working with the older compilers ...
>
> Hi Ulrich,
>
> Thanks for looking into this patch. Sometimes the GDB testsuite is a mystery
> to me. This time it seems to work without parentheses:
>
> old compiler:
> whatis c2
> type = char [2]
> (gdb) PASS: gdb.opencl/datatypes.exp: whatis c2
>
> new compiler:
> whatis c2
> type = char2
> (gdb) PASS: gdb.opencl/datatypes.exp: whatis c2
>
> Any suggestions?
This passes because "char \\\[2\\\]" matches (a substring of) the first
output, but you really want to match the whole string "type = char [2]".
+gdb_test "whatis c2" "type = char(2| \\\[2\\\])"
Andreas.
--
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E
"And now for something completely different."
next prev parent reply other threads:[~2011-02-16 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 20:11 Ken Werner
2011-02-15 21:06 ` Ulrich Weigand
2011-02-16 10:15 ` Ken Werner
2011-02-16 10:24 ` Jan Kratochvil
2011-02-16 10:33 ` Andreas Schwab [this message]
2011-02-16 13:03 ` Ken Werner
2011-02-16 13:55 ` Ulrich Weigand
2011-02-16 14:31 ` Ken Werner
2011-02-16 14:40 ` Ulrich Weigand
2011-02-16 15:38 ` Ken Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3oc6c1dm2.fsf@redhat.com \
--to=schwab@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ken@linux.vnet.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox